Append attachments to comments by flamingo-cant-draw ?? Pull Request #5143 ?? LemmyNet/lemmy

  • flamingos-cant
    link
    fedilink
    English
    arrow-up
    4
    ·
    edit-2
    18 days ago

    We could do what I think you’ve done, and regex the details of the attachment into ! [] ()

    To be clear, this pull request doesn’t use regex, it’s just JSON deserialisation and string interpolation.

    I’ve never actually seen a Mastodon user try to add an image to something that ended up as a Lemmy comment, tbh, so it’s not something I’ve thought too much about.

    The pull request actually includes one, the main KDE account tags !kde@lemmy.kde.social and includes pictures in their threads regularly. It’s just hard to tell from our side as you can’t see what’s missing.

    • Andrew@piefed.social
      link
      fedilink
      English
      arrow-up
      4
      ·
      18 days ago

      Ah, great, thank you. It’s been added as an Issue for PF now, with a link to this post, so that’ll be handy.

      (I was likely misusing the term ‘regex’).