Loving the new link preview position option :)
Is there space for a couple of media tweaks?
- Images, once zoomed in, have this unfortunate feature where moving them by a few pixels brings up the controls layer, and then it’s hard to get rid of—single click zooms back to full image (which is great for quick dismiss). Maybe the controls could be completely disabled if the zoom is anything but ‘fit to screen’ or whatever that default state is known as?
- Videos when rotated often fail to scale properly to the new aspect, getting progressively more and more zoomed.
- Tapping a video in the feed to show it full screen leaves the playback controls visible, then another tap brings up the share / dismiss controls over the top, and then finally a third tap leaves just the video. This feels like it could be smoother—again maybe start with no controls visible?
- Dismissing a video should probably pause playback, as it can be hard to hit the tiny pause button back in the feed.
All sounds good. On the media pause on dismiss, I have auto play disabled, but media continues to play on dismiss so I’m not sure it’s following the setting there…
You were correct; it was disregarding the autoplay setting when dismissing the media viewer. I’ve incorporated all of your suggestions into version 0.4.3.2, which I just released a few minutes ago. I appreciate your feedback, and please let me know if there are any problems with the update.
Thanks for getting to this so quickly—I’ll make separate replies as I get testing to try to keep things organised.
One the ‘zoomed image small pan’, it’s definitely better than before, but what I see now is that there’s a very small threshold below which the image doesn’t move at all, but the controls are shown. And so it can be even harder to hide them again. Let me know if you can’t reproduce that, and I’ll make a recording—but I don’t think the recorder shows the screen tap position so it might be hard to see what’s happening. The basic steps are:
I also see this if the image can’t move if for example it’s very wide aspect and double-tap has left black margins top and bottom—then try dragging slightly up or down and the controls are shown.
Alright, I managed to resolve this. Now small pans will not trigger the controls to appear. I should be releasing an update tonight that will include these fixes.
Thank you for all of that—I’ve tried very hard, but can’t get it to misbehave at all now :) Which means the only thing be got left is the layout between feed and post, which honestly isn’t a huge deal but might be good to have an option like for link previews to keep the order consistent—see this:
Vs:
But even now, the media experience is so much smoother and more enjoyable.
This one is a bit tricky. I’ve noticed the small threshold when dragging where nothing happens, and it can be recognized as a tap. I’m not exactly sure what is causing the dead zone for panning. I have a feeling it is due to 2 gestures waiting to get directional info to decide which one to trigger.
I’ll do some more digging and see what I can come up with. Things get rather convoluted when layering multiple gestures together.
This one still seems to be there… See this example where many times a small drag activates the controls.
Sometimes the drag moves the image, sometimes it doesn’t (not sure if the screen recorder can capture taps / drags?).
Would it be too much to simply disable the controls overlay when zoomed in? Just thinking that might be easier than wrangling the gestures.
Edit: forgot to say that disabling might also solve the issue of accidental single tap before zooming, which currently leaves the controls visible and no simple way to get rid of them without zooming out again.
Alright, I’ve made some progress and believe I’ve finally resolved the issue. It turned out that my previous approach to checking for movement using tap gestures was only detecting movement after the gesture had already been recognized. I’ve updated the code accordingly, and I’ve been spamming pan gestures for the past day without any issues. So far, I haven’t noticed a single instance of the controls showing up.
As an additional layer of security, I might consider disabling the gesture while the user is zoomed, unless the tap occurs within the image margins, where the pan gesture is already not recognized.
On the video side, pause on dismiss is working perfectly, but I did see 2 other problems (great!). One is the zoom on rotate issue—I still see that on first rotation, although it doesn’t get ‘worse’. It ends up showing by about half the media.
But in testing that I noticed that scrubbing the paused video in either full screen or feed view does not appear to affect the playback position where unpaused again—it restarts from where it previously was, not the new position.
Again let me know if recordings would help illustrate.
Well, one down at least.
I took another look at the video rotation this morning. I had made a last minute change before submitting the update yesterday that I thought was harmless, but turns out it broke the rotation fix. I reworked this a bit and it seems to be working fine now.
I completely overlooked saving the playback position while scrubbing if the video is paused. I’ll add this in the next release.
[edit] I added support for saving media resume positions while scrubbing. I’ll still need to do a bit more testing to make sure it is working correctly.