Since there is no way currently to quickly and easily subscribe to a community from the search menu, sharunkumar (not me) added a way to do that in this pull request.

There are 2 poosible designs that are consistent with UI of voyager so I will comment the images of the design below. Upvote the design that you prefer. Please refrain from downvoting.

Also it would be appreciated if the mod (@aeharding@lemmy.world @aeharding@midwest.social) can pin this post (for a day or two) to ensure that it reaches most members of the community

  • Bloody Harry@feddit.deEnglish
    2·
    1 year ago

    A single visual clue should be linked to a single behaviour. Design 2 has two visual clues for one thing (filled heart and crossed out), that’s one too much.

    I’d much rather prefer consistent design with the rest of the app. This would mean a possible Design 3: Stroked heart, no filling, and crossed out when the button will unsubscribe you

    • Sentau@feddit.deOPEnglish
      1·
      1 year ago

      Design 3 would be consistent with this but not with this

      Also it brings to fore a wider debate. Should that button denote the current status or should it denote the action that will happen on pressing the button.

      • Bloody Harry@feddit.deEnglish
        1·
        1 year ago

        A favourite is not a subscription, right? Although, I’ve got to agree with you that a consistent style across favourites and subscriptions would be nice

        • Sentau@feddit.deOPEnglish
          1·
          1 year ago

          No they aren’t the same. I just thought the design would be more consistent as both of them are options living outside the ellipsis menu.

          Also I edited my comment above. Care to weigh in on the discussion there¿?

          • Bloody Harry@feddit.deEnglish
            1·
            1 year ago

            Reading the Apple Human Interface Guideline, it states the following:

            If you use a button that behaves like a toggle, you generally use an interface icon that communicates its purpose, and you update its appearance — typically by changing the background — based on the current state.

            So Design 1 lays closest to best practice. Regarding the ellipsis menu, I’m not sure what to do there. I’d really like a consistent approach, but a stroke-and-filled state might lead to more confusion than what’s there currently. I’m all in on your Design 1 right now.